Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash-cache-tool: Refactors width calculation #2530

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

brooksprumo
Copy link

Problem

There's a lot of code duplication for calculating the printable width of a number.

Summary of Changes

Refactor into new width10() fn.

@brooksprumo brooksprumo self-assigned this Aug 9, 2024
@brooksprumo brooksprumo marked this pull request as ready for review August 9, 2024 14:29
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit 0fda304 into anza-xyz:master Aug 9, 2024
41 checks passed
@brooksprumo brooksprumo deleted the hash-cache-tool/width10 branch August 9, 2024 23:33
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants