Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding bench_poh_recorder_record_transaction_index #2546

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Adding bench_poh_recorder_record_transaction_index #2546

merged 1 commit into from
Aug 16, 2024

Conversation

ksolana
Copy link

@ksolana ksolana commented Aug 12, 2024 •
edited
Loading

Adapted from test_poh_recorder_record_transaction_index

./cargo nightly bench --manifest-path poh/Cargo.toml

test bench_poh_lock_time_per_batch               ... bench:      11,426 ns/iter (+/- 251)
test bench_poh_recorder_record_transaction_index ... bench:       1,334 ns/iter (+/- 106)
test bench_poh_recorder_set_bank                 ... bench:   5,468,741 ns/iter (+/- 255)

@ksolana ksolana requested review from ryoqun and apfitzge August 12, 2024 03:24
apfitzge
apfitzge reviewed Aug 12, 2024
View reviewed changes
poh/benches/poh.rs Outdated Show resolved Hide resolved
@ksolana ksolana force-pushed the benchs branch 5 times, most recently from c13dd68 to c298dab Compare August 13, 2024 22:15
apfitzge
apfitzge reviewed Aug 14, 2024
View reviewed changes
poh/benches/poh.rs Outdated Show resolved Hide resolved
poh/benches/poh.rs Outdated Show resolved Hide resolved
poh/benches/poh.rs Outdated Show resolved Hide resolved
poh/benches/poh.rs Outdated Show resolved Hide resolved
poh/benches/poh.rs Outdated Show resolved Hide resolved
poh/src/poh_recorder.rs Outdated Show resolved Hide resolved
@ksolana ksolana force-pushed the benchs branch 4 times, most recently from c9e5982 to 420633d Compare August 14, 2024 15:16
apfitzge
apfitzge reviewed Aug 14, 2024
View reviewed changes
poh/benches/poh.rs Outdated Show resolved Hide resolved
@ksolana ksolana force-pushed the benchs branch 2 times, most recently from e37ab3b to b20e1d9 Compare August 15, 2024 14:16
apfitzge
apfitzge reviewed Aug 15, 2024
View reviewed changes
poh/benches/poh.rs Outdated Show resolved Hide resolved
@ksolana
Adding bench_poh_recorder_record_transaction_index
9e837d0 
Adapted from test_poh_recorder_record_transaction_index

test bench_poh_recorder_record_transaction_index ... bench:  27,786,204 ns/iter (+/- 1,134,088)
@ksolana ksolana merged commit 1ff046c into anza-xyz:master Aug 16, 2024
40 checks passed
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
@ksolana @ray-kast
Adding bench_poh_recorder_record_transaction_index (anza-xyz#2546)
faf2dd1 
Adapted from test_poh_recorder_record_transaction_index

test bench_poh_recorder_record_transaction_index ... bench:  27,786,204 ns/iter (+/- 1,134,088)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apfitzge apfitzge apfitzge approved these changes

@ryoqun ryoqun Awaiting requested review from ryoqun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksolana @apfitzge