send-transactions: optimize retry pool #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this one needs a rebase to fixup some whitespace lint. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 836 836
Lines 226629 226634 +5
=========================================
+ Hits 185688 185690 +2
- Misses 40941 40944 +3 |
KirillLykov
reviewed
Nov 22, 2024
KirillLykov
reviewed
Nov 22, 2024
KirillLykov
reviewed
Nov 22, 2024
KirillLykov
reviewed
Nov 22, 2024
| @@ -602,7 +628,8 @@ impl SendTransactionService { | |||
| ) -> ProcessTransactionsResult { | |||
| let mut result = ProcessTransactionsResult::default(); | |||
|
|
|||
| let mut batched_transactions = HashSet::new(); | |||
| let mut batched_transactions = Vec::new(); | |||
There was a problem hiding this comment.
I think hashset was used to have unique transaction, could you clarify why it is not needed? Are they already filtered here by construction?
There was a problem hiding this comment.
transactions already unique because filled from transactions object that is HashMap
|
generally good changes, i don't understand some minor details (see questions in the comments) |
fanatid
force-pushed
the
send-transactions-opt-retry-master-based
branch
from
1e6a6fc
to
c7c05af
Compare
|
updated with fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from solana-labs#35081
Problem
Transactions not included in the retry pool on full utilization
Summary of Changes
last_sent_timeinTransactionInfo