stable_log performance improvements #3522
Open
+543
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Bench tests Added unit tests
Updated logging functions for better readability and efficiency by using `join("")` instead of `concat()`. Added extensive tests for multiple logging scenarios and edge cases. Improved benchmarks to compare new and old logging methods across different data sizes and conditions.
Deleted the obsolete `stable_log_old.rs` file previously used for benchmarking improvements. Updated the benchmark references and removed old benchmarks involving the deleted file to streamline the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Improve the performance of stable_log.
Summary of Changes
In stable_log, format! is replaced by manual string concatenation using .join on arrays of string slices (e.g., &["Program ", &program_id.to_string(), ...].join("")). This approach reduces temporary string allocations and slightly improves performance.
The program_data function now preallocates a string with an estimated capacity (String::with_capacity(estimated_capacity)). This helps avoid multiple reallocations as data is appended. Use BASE64_STANDARD.encode_string to encode data directly into the preallocated string buffer instead of creating intermediate strings for each piece of encoded data, enhancing memory efficiency.
Added tests to validate logging behavior under different conditions (e.g., testing logging functions without a collector, handling empty messages, checking success and failure paths, and concurrent collector handling).