Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance test-vectors commit in SVM conformance #3898

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

LucasSte
Copy link

@LucasSte LucasSte commented Dec 3, 2024

Problem

The SVM conformance tests were using an old test-vectors commit.

Summary of Changes

I bumped the commit and made some adaptions in the test environment so that all fixtures could run correctly.

@LucasSte LucasSte marked this pull request as ready for review December 4, 2024 15:35
@LucasSte LucasSte requested a review from a team as a code owner December 4, 2024 15:35
Copy link

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgmt, but just out of curiosity: why not symlink to protosol or add it to the build script somehow? Instead of reimplementing the protobufs here.

@LucasSte
Copy link
Author

LucasSte commented Dec 4, 2024

Lgmt, but just out of curiosity: why not symlink to protosol or add it to the build script somehow? Instead of reimplementing the protobufs here.

I left it like this just because there was no protocol repository when I created this test. I'll look into that improvement. Thanks for the hint.

@LucasSte LucasSte merged commit df27fb3 into anza-xyz:master Dec 4, 2024
40 checks passed
@LucasSte LucasSte deleted the revamp-2 branch December 4, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants