Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IgnoreReclaims in indexgen #4069

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

IgnoreReclaims in indexgen #4069

wants to merge 2 commits into from
+2 −2

Conversation

HaoranYi
Copy link

Problem

We don't need to populate reclaims at index generation time when we call upsert.

Summary of Changes

Ignore populating reclaims at index generation time.

Fixes #

@HaoranYi HaoranYi mentioned this pull request Dec 11, 2024
Open
brooksprumo
brooksprumo reviewed Dec 11, 2024
View reviewed changes
Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change is correct. We are not using/keeping the reclaims parameter on lock_and_update_slot_list(), so there's no need to populate it.

accounts-db/src/accounts_index/in_mem_accounts_index.rs Outdated Show resolved Hide resolved
@HaoranYi HaoranYi requested a review from brooksprumo December 11, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brooksprumo brooksprumo brooksprumo approved these changes

@jeffwashington jeffwashington Awaiting requested review from jeffwashington

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaoranYi @brooksprumo