Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix bookmark temporary item init #254

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

NekoLyn
Copy link
Contributor

@NekoLyn NekoLyn commented Jan 6, 2025

No description provided.

@NekoLyn NekoLyn marked this pull request as draft January 6, 2025 04:52
Copy link
Contributor

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NekoLyn NekoLyn marked this pull request as ready for review January 6, 2025 06:24
Copy link
Contributor

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I suggest you add some test to cover your change

@utas-raymondng utas-raymondng merged commit cb079d5 into main Jan 6, 2025
3 checks passed
@NekoLyn NekoLyn deleted the bugfix/6095-fix-showing-init-temporary-item branch January 7, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants