Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cloudformation template to allow for new bucket access permissions #347

Merged
merged 1 commit into from
Nov 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ $ mvn clean package
## To run integration tests

### Create environment for testing in nonproduction env

First install the aws-wps package to your maven repo:

```
$ mvn clean install
```

wps-cloudformation-template.yml is used to create the followings:
- AWS Batch: Module [aggregation-worker](aggregation-worker) contains the code to do the batch job. During the build,
the maven will invoke docker-build.sh under scripts to create a docker image. You can find the image with the command
Expand All @@ -94,9 +101,9 @@ click the APIs on the top menu and find the ID of your API_ID.
WPS_ENDPOINT=https://$API_ID.execute-api.ap-southeast-2.amazonaws.com/LATEST/wps

```shell
Finally you can run the integrateion-test as below
Finally you can run the integration-testing as below

cd integration-tests
cd integration-testing
WPS_ENDPOINT='https://w4fnovhz73.execute-api.ap-southeast-2.amazonaws.com/LATEST/wps' mvn verify
```

Expand Down
8 changes: 8 additions & 0 deletions wps-cloudformation-template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,14 @@ Resources:
Condition: CreateEphemeralBucket
DeletionPolicy: Delete
Properties:
PublicAccessBlockConfiguration:
BlockPublicAcls: False
BlockPublicPolicy: False
IgnorePublicAcls: True
RestrictPublicBuckets: True
OwnershipControls:
Rules:
- ObjectOwnership: BucketOwnerPreferred
LifecycleConfiguration:
Rules:
- Id: JobExpirationInDays
Expand Down
Loading