Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude survey not done from method list in survey endpoint #1369

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

bpasquer
Copy link
Contributor

@bpasquer bpasquer commented Jun 20, 2024

adresses #1368

@bpasquer bpasquer force-pushed the exclude_survey_no_done branch from 8943ccd to f4cb2a2 Compare December 5, 2024 23:40
@bpasquer bpasquer force-pushed the exclude_survey_no_done branch from f4cb2a2 to 977ca5e Compare December 5, 2024 23:45
Copy link
Contributor

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to run the sql with the test case and the below failed, so looks like this change have more cascade impact

[ERROR] ATRCSurveyGroupCompleteIT.groupWithIncompleteSurveyBlocksShouldFail:242
[ERROR] RLSMethodBlockAssociationIT.missingOnBlockShouldFail:118 expected: but was:
[ERROR] MaterializedViewServiceIT.verifyEpSurveyList:97 Site list first match ==> array contents differ at index [15], expected: but was: <Jan Jansen, Liz Oh>
[ERROR] WormsServiceIT.partialSearchReturnResultEqualsThanFifty:117 Record size match expected:<50> but was:<0>
[ERROR] WormsServiceIT.partialSearchReturnResultLessThanFifty:99 Record size match expected:<14> but was:<0>
[ERROR] WormsServiceIT.partialSearchReturnResultMoreThanFifty:135 Record size match expected:<50> but was:<0>

@utas-raymondng utas-raymondng added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 77b0b1e Dec 18, 2024
3 checks passed
@utas-raymondng utas-raymondng deleted the exclude_survey_no_done branch December 18, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants