Skip to content

Commit

Permalink
Protect against using "hook_params" in "get_hook" until we move to 2.…
Browse files Browse the repository at this point in the history
…3+ (#24706)

The "hook_params" method was added in Airflow 2.3 and we should not
use it in providers (yet).
  • Loading branch information
potiuk authored Jun 28, 2022
1 parent ccd28cb commit 1649f02
Show file tree
Hide file tree
Showing 6 changed files with 127 additions and 117 deletions.
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -334,8 +334,8 @@ repos:
entry: ./scripts/ci/pre_commit/pre_commit_check_setup_extra_packages_ref.py
additional_dependencies: ['rich>=12.4.4']
# This check might be removed when min-airflow-version in providers is 2.2
- id: check-airflow-2-1-compatibility
name: Check that providers are 2.1 compatible.
- id: check-airflow-2-2-compatibility
name: Check that providers are 2.2 compatible.
entry: ./scripts/ci/pre_commit/pre_commit_check_2_2_compatibility.py
language: python
pass_filenames: true
Expand Down
2 changes: 1 addition & 1 deletion STATIC_CODE_CHECKS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ require Breeze Docker image to be build locally.
+--------------------------------------------------------+------------------------------------------------------------------+---------+
| blacken-docs | Run black on python code blocks in documentation files | |
+--------------------------------------------------------+------------------------------------------------------------------+---------+
| check-airflow-2-1-compatibility | Check that providers are 2.1 compatible. | |
| check-airflow-2-2-compatibility | Check that providers are 2.2 compatible. | |
+--------------------------------------------------------+------------------------------------------------------------------+---------+
| check-airflow-config-yaml-consistent | Checks for consistency between config.yml and default_config.cfg | |
+--------------------------------------------------------+------------------------------------------------------------------+---------+
Expand Down
2 changes: 1 addition & 1 deletion dev/breeze/src/airflow_breeze/pre_commit_ids.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'all',
'black',
'blacken-docs',
'check-airflow-2-1-compatibility',
'check-airflow-2-2-compatibility',
'check-airflow-config-yaml-consistent',
'check-airflow-providers-have-extras',
'check-apache-license-rat',
Expand Down
2 changes: 1 addition & 1 deletion images/breeze/output-commands-hash.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# This file is automatically generated by pre-commit. If you have a conflict with this file
# Please do not solve it but run `breeze regenerate-command-images`.
# This command should fix the conflict and regenerate help images that you have conflict with.
906b523aaaaed54525b239a97f3303c1
81bb48610ea6c4b13c1fa5d7d7cbd061
Loading

0 comments on commit 1649f02

Please sign in to comment.