Skip to content

Commit

Permalink
Handle "workflow_run" event properly in selective-check (#24656)
Browse files Browse the repository at this point in the history
Unfortunately testing workflow_run is a bit difficult because
the changes are only effective after merging them.

Fixing (hopefully) yet another mistake in the workflow run where
commit hash was passed as event name (?)

We are going to handle "workflow_run" as valid event type so this
should now work without passing any event.
  • Loading branch information
potiuk authored Jun 26, 2022
1 parent 2ffaebe commit e83e7c8
Show file tree
Hide file tree
Showing 4 changed files with 51 additions and 50 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/label_when_reviewed_workflow_run.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
env:
PR_LABELS: "${{ steps.source-run-info.outputs.pullRequestLabels }}"
COMMIT_REF: "${{ steps.source-run-info.outputs.targetCommitSha }}"
run: breeze selective-check --github-event-name "${{ steps.source-run-info.outputs.targetCommitSha }}"
run: breeze selective-check
- name: "Label when approved by committers for PRs that require full tests"
uses: ./.github/actions/label-when-approved-action
id: label-full-test-prs-when-approved-by-commiters
Expand Down
1 change: 1 addition & 0 deletions dev/breeze/src/airflow_breeze/global_constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ class GithubEvents(Enum):
PULL_REQUEST_TARGET = "pull_request_target"
PUSH = "push"
SCHEDULE = "schedule"
WORKFLOW_RUN = "workflow_run"


@lru_cache(maxsize=None)
Expand Down
2 changes: 1 addition & 1 deletion images/breeze/output-commands-hash.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# This file is automatically generated by pre-commit. If you have a conflict with this file
# Please do not solve it but run `breeze regenerate-command-images`.
# This command should fix the conflict and regenerate help images that you have conflict with.
088f01c27036e2230099add63afb5f6e
b669c8a210166579c58f904d9984d739
Loading

0 comments on commit e83e7c8

Please sign in to comment.