Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM image building for regular PRs #24661

Closed
wants to merge 1 commit into from

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 25, 2022

The image building for ARM is currently only done in the main build
only to refresh cache, however there are sometimes cases when
new dependency (for example #24635) broke ARM image build and it
was only discovered after merge.

This PR adds extra ARM-based build that should be run after
the AMD64 build. It should not influence the depending steps,
it should just signal failure of the PR if the ARM image cannot
be build.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Jun 25, 2022

cc: @gmsantos

@potiuk potiuk force-pushed the add-arm-image-building branch 6 times, most recently from dbcf01b to 4da6004 Compare June 26, 2022 09:28
The image building for ARM is currently only done in the main build
only to refresh cache, however there are sometimes cases when
new dependency (for example apache#24635) broke ARM image build and it
was only discovered after merge.

This PR adds extra ARM-based build that should be run after
the AMD64 build. It should not influence the depending steps,
it should just signal failure of the PR if the ARM image cannot
be build.
@potiuk potiuk force-pushed the add-arm-image-building branch from 4da6004 to 5be0282 Compare June 26, 2022 10:14
@potiuk
Copy link
Member Author

potiuk commented Jun 27, 2022

Closing in favour of the change that can test it in "apache" repo #24664

@potiuk potiuk closed this Jun 27, 2022
@potiuk potiuk deleted the add-arm-image-building branch July 29, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant