-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger openlineage test when asset files changes #44172
Trigger openlineage test when asset files changes #44172
Conversation
f6f0a93
to
cbc69b5
Compare
Two small comments. |
…m:astronomer/airflow into trigger-openlineage-tests-on-asset-change
Thank you for the suggestions. I have implemented the suggested changes. |
…m:astronomer/airflow into trigger-openlineage-tests-on-asset-change
Can you elaborate what broke in OL? I’m not sure |
@uranusjr This issue explain more about what broke in OL. Also, this PR was raised to fix OL tests. I asked @Lee-W for the assets file we can remove these files |
I believe @uranusjr's point is more convincing. Although those are related to assets, they are using assets and are unlikely to affect OL. I should have thought it through more thoroughly. |
Thanks, @Lee-W and @uranusjr for the suggestion. I will remove |
@vatsrahul1001 should we resolve the discussions or are we waiting for @potiuk 's confirmation? or |
We can resolve the discussion. @potiuk, is it good to merge? |
Good to go, merged :) |
Description
Adding
FileGroupForCi.ASSET_FILES
and running Openlineage test when Assets files are changed.Motivation:
We recently noticed PR broke OL tests as
openlineage
tests heavily rely on assets and are often broken after asset changes. We want to trigger OL test whenever there is a change in Asset related files.closes: #44026
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.