Migrate public endpoint Patch Task Instance to FastAPI #44223
+1,192
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
omkar-foss
added
the
legacy api
2 tasks
omkar-foss
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
ephraimbuddy
as code owners
|
All checks passed, PR is ready for review ✅ |
|
@pierrejeambrun I'm adding the Set Task Instance Note functionality to this (Patch Task Instance) API as you mentioned here. Will update this PR in a while. |
omkar-foss
force-pushed
the
aip-84/tis/patch-ti
branch
from
addcfe1
to
f6c3f24
Compare
Kludex
reviewed
Nov 21, 2024
@pierrejeambrun I've added Yes got it, sure, I've closed the other Set Task Instance State PR #44246. |
omkar-foss
commented
Nov 21, 2024
| for field in fields_to_update: | ||
| if field == "new_state": | ||
| if not body.dry_run: | ||
| tis: list[TI] = dag.set_task_instance_state( |
There was a problem hiding this comment.
Are these to be included for updation as well? Let me know if required I'll add these too.
upstream=body.include_upstream,
downstream=body.include_downstream,
future=body.include_future,
past=body.include_past,
...
omkar-foss
force-pushed
the
aip-84/tis/patch-ti
branch
from
3cb7311
to
7737a0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #43753, #43754 and #43752
related: #42370
This migrates the Patch Task Instance API from
api_connexiontoapi_fastapi.