Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit google-cloud-aiplatform to fix issues in CI #46242

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

amoghrajesh
Copy link
Contributor

From the last failure https://github.com/apache/airflow/actions/runs/13032455156/job/36355532907, looks like sklearn is not a dependency on google provider. Using the latest stable version: https://scikit-learn.org/stable/auto_examples/release_highlights/plot_release_highlights_1_6_0.html


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@amoghrajesh amoghrajesh requested a review from potiuk January 29, 2025 15:13
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jan 29, 2025
@amoghrajesh amoghrajesh changed the title Adding sklearn as a dependency for google provider Limit google-cloud-aiplatform to fix issues in CI Jan 29, 2025
@potiuk
Copy link
Member

potiuk commented Jan 29, 2025

Can you also create an issue for that so we do not forget to take care of that later ?

@jscheffl
Copy link
Contributor

Seems next canary is also failing as the PR is open: https://github.com/apache/airflow/actions/runs/13038931877/job/36376833483

@amoghrajesh
Copy link
Contributor Author

I think we can merge if failures are unrelated to unblock

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jscheffl
Copy link
Contributor

Merging. All errors in CI checks are residual leftovers of other problems, this PR still improves the broken main state.

@jscheffl jscheffl merged commit e3baba0 into apache:main Jan 29, 2025
142 of 154 checks passed
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* Adding sklearn as a dependency for google provider

* limiting google cloud aiplatform instead

* Add link to bug ticket

---------

Co-authored-by: Jens Scheffler <[email protected]>
dabla pushed a commit to dabla/airflow that referenced this pull request Jan 30, 2025
* Adding sklearn as a dependency for google provider

* limiting google cloud aiplatform instead

* Add link to bug ticket

---------

Co-authored-by: Jens Scheffler <[email protected]>
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Jan 30, 2025
* Adding sklearn as a dependency for google provider

* limiting google cloud aiplatform instead

* Add link to bug ticket

---------

Co-authored-by: Jens Scheffler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants