feat: Support config merge from Kubernetes Secret #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Adolfo Agulló <[email protected]>
|
Great changes! So we can use the credentials in a safe way |
|
Let's close this PR as null response given |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We have detected that some of the credentials regarding configuration are hardcoded on
values.yaml. We needed to fix this for our company as we use ExternalSecrets operator to provide the credentials dynamically to the Kubernetes clusters.We have patched the Helm chart to be able to merge some config coming from a Kubernetes Secret with the main config coming from the dashboard's configmap. This way we cover all the potential secret fields across config (etc, authentication users, etc)
For merging we are using the official
yqimage so we expect you like itWDYT about changes?