feat: support adding annotations to Deployment #697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing to add annotations for Deployment object of
apisix-ingress-controller
makes usage of 3rd party tools likereloader
possible, e.g.:Use case: We are delivering admin key to Kubernetes using
external-secrets-operator
and then passing into apisix via environment variable, and we want ingress controllers to be automatically reloaded when update of secret happens. For this purpose, we need to be able to addreloader
annotation to the deployment object.