fix(traffic-split): upstream_obj.upstream
should not be a string
#11932
+100
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During creation of roundrobin object for upstream in traffic-split.
upstream_obj.upstream
: 1 is assigned a string if the upstream configuration only has the weight value.In this case, if we reload the plugin via the plugin reload API. The roundrobin object gets recreated but since
upstream_obj.upstream
has a string value.upstream_obj.upstream.vid = i
: 2 causes panic because it expectsupstream_obj
to be a table.Checklist