Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Bruce Ritchie <[email protected]>
  • Loading branch information
alamb and Omega359 authored Nov 24, 2024
1 parent 6a788ae commit a3048c5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions arrow-array/src/builder/generic_bytes_view_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ impl<T: ByteViewType + ?Sized> GenericByteViewBuilder<T> {
/// - String length exceeds `u32::MAX`
#[inline]
pub fn append_str(&mut self, value: &str) {
// SAFETY: UTF8 bytes are valid for both string and binaary
// SAFETY: UTF8 bytes are valid for both string and binary
unsafe { self.append_bytes(value.as_bytes()) }
}

Expand Down Expand Up @@ -430,7 +430,7 @@ impl<T: ByteViewType + ?Sized> GenericByteViewBuilder<T> {
buffer_size + in_progress + tracker + views + null
}

/// Return a structure that implements `std::fmt::Write` to write stirngs
/// Return a structure that implements `std::fmt::Write` to write strings
/// directly to the builder. See example on [`StringViewBuilder`]
pub fn formatter(&mut self) -> ByteViewFormatter<'_, T> {
ByteViewFormatter::new(self)
Expand Down Expand Up @@ -677,7 +677,7 @@ where
}
}

/// When a StringViewWriter is dropped, it writes the the value to the StringViewBuilder
/// When a StringViewWriter is dropped, it writes the value to the StringViewBuilder
impl<'a, T> Drop for ByteViewFormatter<'a, T>
where
T: ByteViewType + ?Sized,
Expand Down

0 comments on commit a3048c5

Please sign in to comment.