Relaxing type bounds on coalesce_ranges and collect_bytes #4787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumerman
force-pushed
the
std-err-in-pub-util-pr
branch
2 times, most recently
from
60b9e85 to
64e0219
Compare
tustvold
reviewed
Sep 7, 2023
object_store/src/util.rs
Outdated
| pub async fn collect_bytes<S, E>( | ||
| mut stream: S, | ||
| size_hint: Option<usize>, | ||
| ) -> StdResult<Bytes, E> |
There was a problem hiding this comment.
Suggested change
| ) -> StdResult<Bytes, E> | |
| ) -> Result<Bytes, E> |
The type def just defaults to object_store::Error
to allow using them with a wider range of Error types.
sumerman
force-pushed
the
std-err-in-pub-util-pr
branch
from
64e0219 to
87d87e5
Compare
tustvold
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
A followup to #4784
Rationale for this change
Now that
coalesce_rangesandcollect_byteswere made public the next logical step is to relax their type bounds. Thus allowing to use them with a wider range ofErrortypes.What changes are included in this PR?
Are there any user-facing changes?