Pushdown list_with_offset for GCS #4993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would appear our mock GCS server doesn't handle this correctly :( - I did confirm this works against GCS proper though |
|
As far as I can tell, we're using an emulator image that you've built. Did you update that image recently? Seems like the upstream project is rather active and might have fixed that issue already. |
|
Still waiting on fsouza/fake-gcs-server#1164 The activity seems to mostly be dependabot |
|
fsouza/fake-gcs-server@46f2f72 fixes the upstream to support this |
crepererum
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Noticed whilst working on #4984, GCS exposes the same list API as S3 and so we can support this parameter in the same way
What changes are included in this PR?
Are there any user-facing changes?