-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ObjectStore: make error msg thrown from retry more detailed #5012
Merged
tustvold
merged 3 commits into
apache:master
from
Rachelint:optimize-object-store-error-msg
Nov 1, 2023
Merged
ObjectStore: make error msg thrown from retry more detailed #5012
tustvold
merged 3 commits into
apache:master
from
Rachelint:optimize-object-store-error-msg
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
changed the title
optimize error msg for better debugging.
ObjectStore: make error msg thrown from retry more detailed
Nov 1, 2023
Rachelint
force-pushed
the
optimize-object-store-error-msg
branch
from
November 1, 2023 05:44
2dd963b
to
f9116f3
Compare
I think some of the tests need updating |
Ok, I will fix it soon. |
alamb
reviewed
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Rachelint 🙏
tustvold
approved these changes
Nov 1, 2023
Rachelint
force-pushed
the
optimize-object-store-error-msg
branch
from
November 1, 2023 15:27
3588530
to
d8cd079
Compare
Thank you for sticking with this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5013
Rationale for this change
I found it is difficult to locate the cause of the thrown error when using
object_store
crate in our project, due to information in error msg is not enough. So I hope such error msg can be more detailed and make it in this pr.What changes are included in this PR?
Add more info to the error in
object_store/src/client/retry.rs
for better debugging.Are there any user-facing changes?
None.