Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectStore: make error msg thrown from retry more detailed #5012

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Nov 1, 2023

Which issue does this PR close?

Closes #5013

Rationale for this change

I found it is difficult to locate the cause of the thrown error when using object_store crate in our project, due to information in error msg is not enough. So I hope such error msg can be more detailed and make it in this pr.

What changes are included in this PR?

Add more info to the error in object_store/src/client/retry.rs for better debugging.

Are there any user-facing changes?

None.

@github-actions github-actions bot added the object-store Object Store Interface label Nov 1, 2023
@Rachelint Rachelint changed the title optimize error msg for better debugging. ObjectStore: make error msg thrown from retry more detailed Nov 1, 2023
@Rachelint Rachelint force-pushed the optimize-object-store-error-msg branch from 2dd963b to f9116f3 Compare November 1, 2023 05:44
@Rachelint
Copy link
Contributor Author

PTAL @tustvold @alamb

@tustvold
Copy link
Contributor

tustvold commented Nov 1, 2023

I think some of the tests need updating

@Rachelint
Copy link
Contributor Author

I think some of the tests need updating

Ok, I will fix it soon.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Rachelint 🙏

@Rachelint
Copy link
Contributor Author

Rachelint commented Nov 1, 2023

@tustvold @alamb thanks for review and sorry for the late reply due to the meeting 😊
I have fixed the failed test.

@Rachelint Rachelint force-pushed the optimize-object-store-error-msg branch from 3588530 to d8cd079 Compare November 1, 2023 15:27
@tustvold tustvold merged commit 7873500 into apache:master Nov 1, 2023
13 checks passed
@tustvold
Copy link
Contributor

tustvold commented Nov 1, 2023

Thank you for sticking with this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObjectStore: hard to determine the cause of the error thrown from retry
3 participants