Relax path safety (#5019) #5020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Nov 1, 2023
| @@ -196,6 +225,11 @@ impl From<Error> for super::Error { | |||
| /// * Mutating a file through one or more symlinks will mutate the underlying file | |||
| /// * Deleting a path that resolves to a symlink will only delete the symlink | |||
| /// | |||
| /// # Cross-Filesystem Copy | |||
There was a problem hiding this comment.
This is not a change in this PR, but is something I felt worth documenting whilst I remembered
crepererum
reviewed
Nov 2, 2023
| /// * Windows forbids certain ASCII characters, e.g. `<` or `|` | ||
| /// * OS X forbids filenames containing `:` | ||
| /// * Leading `-` are discouraged on Unix systems where they may be interpreted as CLI flags | ||
| /// * Filesystems may have restrictions on the maximum path or path segment length |
There was a problem hiding this comment.
Suggested change
| /// * Filesystems may have restrictions on the maximum path or path segment length | |
| /// * Stores (both filesystems and cloud providers) may have restrictions on the maximum path or path segment length |
This is actually a real issue I've ran into in a past project.
There was a problem hiding this comment.
👍 I will add this to the docs on Path proper
crepererum
approved these changes
Nov 2, 2023
| /// * OS X forbids filenames containing `:` | ||
| /// * Leading `-` are discouraged on Unix systems where they may be interpreted as CLI flags | ||
| /// * Filesystems may have restrictions on the maximum path or path segment length | ||
| /// * Filesystem support for non-ASCII characters is inconsistent |
There was a problem hiding this comment.
FWIW: what we could do for FS (although that wouldn't be backwards compatible) is to percent-encode the path segments.
There was a problem hiding this comment.
Yeah, the challenge is knowing ahead of time what character are permitted. We don't want to be in something similar to the current situation because we assume that people won't create paths with weird characters
This was referenced Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5019
Rationale for this change
See ticket
What changes are included in this PR?
Are there any user-facing changes?