Add a PR under "Breaking changes" in the object_store 0.8.0 changelog #5063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a method, `put_opts`, to the `ObjectStore` trait, so any implementer of this trait will need to update their code when they upgrade to 0.8.0.
|
Thank you for this, it slipped under the radar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR added to the changelog here adds a method,
put_opts, to theObjectStoretrait, so any implementer of this trait will need to update their code when they upgrade to 0.8.0.Which issue does this PR close?
I will file an issue if you realllyyyy want me to, but do you need a changelog entry for a fix to the changelog? 🤔
Rationale for this change
I tried updating the IOx codebase from object_store 0.7.1 to 0.8.0 and got errors about an implementation of
ObjectStoremissingput_opts. I went to the changelog to learn more about the change, and I couldn't find the information I needed because the PR that added this method wasn't under the breaking changes section and searching the changelog for "put_opts" didn't return results either :)What changes are included in this PR?
Adding a PR to the Breaking Changes section of the object_store 0.8.0 changelog.
Are there any user-facing changes?
This is some documentation for the user-facing change made previously :)