Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write null counts in parquet files when they are present #6257

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'apache/master' into alamb/parquet_null_…
…counts
  • Loading branch information
alamb committed Oct 1, 2024
commit 6c05e60219a1352ef2049f8269477f9b317e74d0
8 changes: 4 additions & 4 deletions parquet/src/arrow/arrow_reader/statistics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1198,10 +1198,10 @@ impl<'a> StatisticsConverter<'a> {
/// By default, the converter will treat missing null counts as though
/// the null count is known to be `0`.
///
/// Note that due to <https://github.com/apache/arrow-rs/pull/6257>, prior
/// to version 53.0.0, parquet files written by parquet-rs did not store
/// null counts even when it was known there were zero nulls and the reader
/// would return 0 for the null counts.
/// Note that parquet files written by parquet-rs currently do not store
/// null counts even when it is known there are zero nulls, and the reader
/// will return 0 for the null counts in that instance. This behavior may
/// change in a future release.
///
/// Both parquet-java and parquet-cpp store null counts as 0 when there are
/// no nulls, and don't write unknown values to the null count field.
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.