Read nested Parquet 2-level lists correctly #6757
Open
+115
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devanbenz
reviewed
Nov 20, 2024
parquet/src/schema/types.rs
Outdated
|
|
||
| /// Returns `true` if this type is annotated as a list. | ||
| pub fn is_list(&self) -> bool { | ||
| match self.is_group() { |
There was a problem hiding this comment.
Since .is_group() returns a boolean wouldn't it be better semantics to put it inside a branch conditional just using if?
There was a problem hiding this comment.
I think Rust has warped me...I feel like I'm doing it wrong if I use if 😅. But you're right that it would be more succinct.
devanbenz
reviewed
Nov 20, 2024
| use arrow::datatypes::ToByteSlice; | ||
|
|
||
| let testdata = arrow::util::test_util::parquet_test_data(); | ||
| // message my_record { |
There was a problem hiding this comment.
Nice, thank you for putting a comment with the test data. I like this :)
I wish I could 😅. It appears that test is borked for everyone due to some upstream shenanigans. And now fixed by #6745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6756.
Rationale for this change
See issue.
What changes are included in this PR?
Modifies both the arrow and record readers to check for nested lists before triggering the rule that repeated groups named "array" are treated as
list<OneTuple>.Are there any user-facing changes?
Changes the interpretation of some legacy schemas.