Support shrink to empty #6817
Support shrink to empty #6817
Conversation
tustvold
force-pushed
the
shrink-to-empty
branch
from
0ee84f4
to
5d1abfe
Compare
|
FYI @emilk |
arrow-buffer/src/buffer/mutable.rs
Outdated
| @@ -468,7 +468,7 @@ impl MutableBuffer { | |||
| } | |||
|
|
|||
| #[inline] | |||
| fn dangling_ptr() -> NonNull<u8> { | |||
| pub(crate) fn dangling_ptr() -> NonNull<u8> { | |||
| // SAFETY: ALIGNMENT is a non-zero usize which is then casted | |||
| // to a *mut T. Therefore, `ptr` is not null and the conditions for | |||
There was a problem hiding this comment.
Not introduced in this PR, but this function isn't generic, so I am not sure what *mut T is talking about
There was a problem hiding this comment.
I think this is a copy-pasta from NonNull::dangling
| @@ -468,7 +468,7 @@ impl MutableBuffer { | |||
| } | |||
|
|
|||
| #[inline] | |||
| fn dangling_ptr() -> NonNull<u8> { | |||
| pub(crate) fn dangling_ptr() -> NonNull<u8> { | |||
There was a problem hiding this comment.
I suggest adding some some comments about this function given its name.
Specifically, that it returns a valid, u8 pointer that is valid for the entire life of the process. Suitable for allocations of 0 length.
I realize it wasn't introduced in this PR, but the name is confusing to me -- Maybe calling it arbtrary_ptr() or something would be less confusing 🤔
There was a problem hiding this comment.
Yeah dangling is an odd name, but is based on what the standard library calls it. I have added some docs to this effect
Which issue does this PR close?
Closes #.
Rationale for this change
Follow up to #6790
What changes are included in this PR?
Are there any user-facing changes?