Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parquet gzip compression performance using zlib-rs #7200

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve parquet gzip compression performance using zlib-rs #7200

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09cee31
Improve parquet gzip compression performance using zlib-rs
psvri Feb 26, 2025
3071e71
Merge remote-tracking branch 'apache/main' into improve_parquet_gzip_…
alamb Mar 12, 2025
2dba5ec
Merge remote-tracking branch 'apache/main' into improve_parquet_gzip_…
alamb Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parquet/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ bytes = { version = "1.1", default-features = false, features = ["std"] }
thrift = { version = "0.17", default-features = false }
snap = { version = "1.0", default-features = false, optional = true }
brotli = { version = "7.0", default-features = false, features = ["std"], optional = true }
flate2 = { version = "1.0", default-features = false, features = ["rust_backend"], optional = true }
flate2 = { version = "1.1", default-features = false, features = ["zlib-rs"], optional = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this pure-rust? Does this compile for wasm32-unknown-unknown?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. its written in pure rust.

In my fork I can see wasm32 pipeline not failing https://github.com/psvri/arrow-rs/actions/runs/13547936797/job/37864105483

lz4_flex = { version = "0.11", default-features = false, features = ["std", "frame"], optional = true }
zstd = { version = "0.13", optional = true, default-features = false }
chrono = { workspace = true }
Expand Down
2 changes: 1 addition & 1 deletion parquet/src/compression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ impl Default for GzipLevel {

impl CompressionLevel<u32> for GzipLevel {
const MINIMUM_LEVEL: u32 = 0;
const MAXIMUM_LEVEL: u32 = 10;
const MAXIMUM_LEVEL: u32 = 9;
}

impl GzipLevel {
Expand Down
Loading