Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Parquet API interaction for u64 #7252

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Change Parquet API interaction for u64 #7252

wants to merge 3 commits into from
+85 −55

Conversation

alchemist51
Copy link

@alchemist51 alchemist51 commented Mar 8, 2025 •
edited by alamb
Loading

Which issue does this PR close?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Mar 8, 2025
@alchemist51 alchemist51 changed the title Change AsyncFileReader trait for u64 Change Parquet API interaction for u64 Mar 8, 2025
@alchemist51 alchemist51 mentioned this pull request Mar 8, 2025
Open
@alchemist51
Copy link
Author

alchemist51 commented Mar 8, 2025 •
edited
Loading

I'm trying to change the trait AsyncFileReader to accept the u64 types instead of usize while keeping the other traits the same.

I was trying to do check for what traits we could change in for ParquetWriter though was not able to conclude on it.

Pretty new to the arrow-rs community and raising my first PR! Any feedback is welcome! @alamb @tustvold

@alchemist51 alchemist51 marked this pull request as ready for review March 9, 2025 18:38
tustvold
tustvold reviewed Mar 11, 2025
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking promising thank you. Just to set expectations as this will be a breaking change it will need to wait for the next breaking release, likely scheduled for April.

parquet/src/arrow/async_reader/metadata.rs Outdated
@@ -71,7 +71,7 @@ pub trait MetadataFetch {

impl<T: AsyncFileReader> MetadataFetch for &mut T {
fn fetch(&mut self, range: Range<usize>) -> BoxFuture<'_, Result<Bytes>> {
self.get_bytes(range)
self.get_bytes(range.start as u64..range.end as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also change this trait

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@tustvold tustvold added api-change Changes to the arrow API next-major-release the PR has API changes and it waiting on the next major version labels Mar 11, 2025
@alamb alamb marked this pull request as draft March 12, 2025 20:36
@alamb
Copy link
Contributor

alamb commented Mar 12, 2025

Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look

@alchemist51 alchemist51 force-pushed the change-parquet-usize branch from 48b297d to 11aa2cb Compare March 15, 2025 08:05
@alchemist51 alchemist51 marked this pull request as ready for review March 15, 2025 08:15
@alchemist51
update metadatafetch trait
fef3719 
Signed-off-by: Arpit Bandejiya <[email protected]>
@alchemist51 alchemist51 force-pushed the change-parquet-usize branch from 03469ad to fef3719 Compare March 15, 2025 08:44
@alchemist51
Copy link
Author

Sorry about the delay @tustvold @alamb . have updated the PR. Please review.

@alchemist51
Copy link
Author

This is looking promising thank you. Just to set expectations as this will be a breaking change it will need to wait for the next breaking release, likely scheduled for April.

Is there any annotation or any file where I need to add these traits to mark for breaking change?

@alchemist51 alchemist51 requested a review from tustvold March 15, 2025 13:41
@alamb
Copy link
Contributor

alamb commented Mar 17, 2025

This is looking promising thank you. Just to set expectations as this will be a breaking change it will need to wait for the next breaking release, likely scheduled for April.

Is there any annotation or any file where I need to add these traits to mark for breaking change?

I think we just need to add a github label with "api change" which we have done

@alchemist51
Copy link
Author

@tustvold could you please run the workflows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold Awaiting requested review from tustvold

Assignees
No one assigned
Labels
api-change Changes to the arrow API next-major-release the PR has API changes and it waiting on the next major version parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parquet Use U64 Instead of Usize
3 participants
@alchemist51 @alamb @tustvold