-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add append_array
for some array builder implementations
#7309
base: main
Are you sure you want to change the base?
Conversation
append_array
for PrimitiveBuilder
append_array
for some array builder implementations
What is the motivation for adding these here, as opposed to just using the array constructors to implement concat? IMO if you aren't constructing by value, there's no point using the builders? |
The motivation is:
|
I've pushed the concat updated implementation so you can run the benchmarks locally, for me:
|
This seems like quite a fair bit of code and codegen to shave off literal nanoseconds, no? Do we see similar returns for the byte array types? Also as this is really just reducing the dispatch overheads, I would expect as the array sizes increase the return would largely disappear. I dunno I am always pretty wary of adding new unsafe APIs... |
# Conflicts: # arrow-buffer/src/builder/null.rs
This is on top of
append_buffer
forNullBufferBuilder
#7308Which issue does this PR close?
N/A
Rationale for this change
This is a building block for implementing specialized concat
What changes are included in this PR?
added
append_array
function for:PrimitiveBuilder
,GenericByteBuilder
andBooleanBuilder
with testsconcat
to use this specialized implementationAre there any user-facing changes?
Yes, new method.
Local benchmark results: