-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default wasm32-unknown-unknown client #7310
base: main
Are you sure you want to change the base?
Default wasm32-unknown-unknown client #7310
Conversation
…1st party HttpService implementation for wasm32-unknown-unknown.
We'll need a definitive position from maintainers on which of the following is preferred to resolve the ambiguity surrounding wasm32-unknown-unknown:
|
Also, two things:
|
Thank you for this PR. We are in the process of moving the object_store code to its own repository. Would it be possible for you to create a PR in that repository instead?
(we will handle moving all existing issues to the new repository) |
I don't know enough about wasm to have a useful opinion here Perhaps @kylebarron or @XiangpengHao can help out with an answer |
I think the get_random on So it's already quite a hassle to use it on js-based platforms. That said, I only used wasm-unknown-unknown on the JS platform and do not have enough knowledge to comment on other combinations. |
Which issue does this PR close?
Closes #7227 .
What changes are included in this PR?
Target-gated wasm32-unknown-unknown reqwest-based HttpConnector (with explicit handling surrounding non-Send, non-Sync futures).
Are there any user-facing changes?
wasm32-unknown-unknown users will need to add the
getrandom = { version = "*", features = ["js"] }
cargo entry if they aren't already using it. The alternative would be to feature flag in a similar manner to chrono, getrandom, zstd (i.e. 'js').