-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Website]: Redirect existing docs from https://arrow.apache.org/ to https://datafusion.apache.org/ #502
Conversation
@@ -27,4 +27,5 @@ group :jekyll_plugins do | |||
gem "jekyll-feed", "~> 0.6" | |||
gem "jekyll-jupyter-notebook" | |||
gem "jekyll-seo-tag" | |||
gem 'jekyll-redirect-from' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not really familiar with Jekyll and thus I don't know if this is the right approach or not for creating a redirect 🤔 It seems to work but has lots of repeititon
Ideally I would like to just make a table with old URLs and redirects but I couldn't figure out how to do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kou I think you are a Jekyll expert (at least are more knowledgable than I am) -- is this a reasonable way to implement redirects for the arrow-site? Or is there a better / preferred way?
@@ -0,0 +1,94 @@ | |||
# Creates redirect URLS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the script I used to create the content in this PR -- in case anyone is interested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - thanks for taking this on! One minor nit, but its very minor so feel free to ignore.
Co-authored-by: Phillip LeBlanc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @phillipleblanc
@@ -27,4 +27,5 @@ group :jekyll_plugins do | |||
gem "jekyll-feed", "~> 0.6" | |||
gem "jekyll-jupyter-notebook" | |||
gem "jekyll-seo-tag" | |||
gem 'jekyll-redirect-from' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kou I think you are a Jekyll expert (at least are more knowledgable than I am) -- is this a reasonable way to implement redirects for the arrow-site? Or is there a better / preferred way?
It seems that we can use How about trying diff --git a/.htaccess b/.htaccess
new file mode 100644
index 00000000000..e19ec2a4fbd
--- /dev/null
+++ b/.htaccess
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+Redirect permanent /datafusion/ https://datafusion.apache.org/ |
Thanks @kou -- I will give it a try |
…sion to https://datafusion.apache.org/ (#505) Closes apache/datafusion#10194 Closes #502 Per @kou 's suggestion in #502 (comment), this PR adds a `.htaccess` file with a redirect from all `www.apache.org/datafusion` urls to `datadfusion.apache.org` urls (I think) Documentaiton on these files is here: https://infra.apache.org/project-site.html I don't really know how to test this other than "in production"
Closes apache/datafusion#10194
Closes apache/datafusion#10124
Rationale
We would like to redirect existing datafusion pages / links to the new website on https://datafusion.apache.org/ apache/datafusion#10194 for more rationale
Changes
Testing locally when you navigate to the
DataFusion
link it correctly redirectshttp://localhost:4000/datafusion redirects to https://datafusion.apache.org/
Testing
I tested manually
https://arrow.apache.org/datafusion/user-guide/introduction.html
Changed to
http://localhost:4000/datafusion/user-guide/introduction.html
Redirects to
https://datafusion.apache.org/user-guide/introduction.html
https://arrow.apache.org/datafusion/library-user-guide/working-with-exprs.html
changed to
http://localhost:4000/datafusion/library-user-guide/working-with-exprs.html
redirects to
https://datafusion.apache.org/library-user-guide/working-with-exprs.html
I also checked the url from apache/datafusion#10124
https://arrow.apache.org/datafusion/user-guide/cli.html
Changed to
http://localhost:4000/datafusion/user-guide/cli.html
Redirects to
https://datafusion.apache.org/user-guide/cli/index.html
https://arrow.apache.org/datafusion/user-guide/cli/index.html
Changed to
http://localhost:4000/datafusion/user-guide/cli/index.html
Redirects to
https://arrow.apache.org/datafusion/user-guide/cli/index.html