Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [C++] Fix a typo #39053

Merged
merged 1 commit into from
Dec 5, 2023
Merged

MINOR: [C++] Fix a typo #39053

merged 1 commit into from
Dec 5, 2023

Conversation

llama90
Copy link
Contributor

@llama90 llama90 commented Dec 3, 2023

Rationale for this change

Noticed a typo on the code and proposing a fix

Are these changes tested?

Yes. It is passed by existing test cases.

Are there any user-facing changes?

No

cpp/src/arrow/array/array_dict.cc Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 5, 2023
@pitrou pitrou merged commit 9b03ffb into apache:main Dec 5, 2023
34 checks passed
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Dec 5, 2023
@pitrou
Copy link
Member

pitrou commented Dec 5, 2023

Thanks @llama90 .

Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 9b03ffb.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

Noticed a typo on the code and proposing a fix

### Are these changes tested?

Yes. It is passed by existing test cases.

### Are there any user-facing changes?

No

Authored-by: Hyunseok Seo <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants