-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] add metrics: total_entry_log_space_bytes #4507
[improve] add metrics: total_entry_log_space_bytes #4507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, It is also recommended to add a test
reopen's reason: rerun failure checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little hesitat, I prefer to remove TOTAL_
perfix, it's common appears as suffix to indicate it's type. Put it in front doesn't bring additional information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
For the name: we sure follow current conventions in the project codebase |
@eolivelli I didn't see |
+1, It might be better to change total_entry_log_space_bytes to entry_log_space_bytes. |
@StevenLuMT thx, make sense. updated. |
Please fix the checkstyle error. Otherwise LGTM.
|
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookKeeperServerStats.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Zhangjian He <[email protected]>
@ethqunzhong please fix it |
Thanks for your contribution. :) |
Motivation
add metric
TOTAL_ENTRY_LOG_SPACE_BYTES
As a supplement to metricACTIVE_ENTRY_LOG_SPACE_BYTES
This allows us to easily analyze the proportion of valid data in the cluster entry log.
Changes
TOTAL_ENTRY_LOG_SPACE_BYTES
in GarbageCollectorStats.