[CALCITE-6624] SqlBabelParser should parse MySQL DATETIME type #4002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dssysolyatin
force-pushed
the
feature/support-mysql-datetime-type-parsing
branch
from
b24d053
to
86e204b
Compare
mihaibudiu
reviewed
Oct 11, 2024
| @@ -6182,6 +6182,12 @@ SqlTypeNameSpec DateTimeTypeName() : | |||
| { | |||
| return new SqlBasicTypeNameSpec(typeName, precision, s.end(this)); | |||
| } | |||
| | | |||
There was a problem hiding this comment.
is this supposed to be in Babel?
There was a problem hiding this comment.
Regarding Babel, my initial plan was to implement DATETIME datatype parsing at the Babel parser level, but I noticed that we have DATETIME literal parsing for BigQuery inside Parser.jj, which is also valid for MySQL. Therefore, I decided to put DATETIME type parsing in Parser.jj, as it would be better to have both DATETIME datatype parsing and DATETIME literal parsing in the same place.
dssysolyatin
force-pushed
the
feature/support-mysql-datetime-type-parsing
branch
2 times, most recently
from
492a2ae
to
2833f46
Compare
dssysolyatin
force-pushed
the
feature/support-mysql-datetime-type-parsing
branch
from
2833f46
to
42206a9
Compare
dssysolyatin
changed the title
|
Please retry analysis of this Pull-Request directly on SonarCloud |
mihaibudiu
reviewed
Nov 18, 2024
|
|
||
| !ok | ||
|
|
||
| SELECT cast(cast(TIMESTAMP'9999-12-31 23:59:59' as DATETIME) as DATETIME); |
There was a problem hiding this comment.
Can you also write DATETIME '1000-01-01 00:00:00'?
Are you supposed to?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.