Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-6649] Enhance RelMdPredicates pull up predicate from PROJECT #4021

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[CALCITE-6649] Enhance RelMdPredicates pull up predicate from PROJECT #4021

wants to merge 1 commit into from

Conversation

NobiGo
Copy link
Contributor

@NobiGo NobiGo commented Oct 29, 2024

No description provided.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mihaibudiu
mihaibudiu approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@mihaibudiu mihaibudiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this is not too expensive; some of these objects are reallocated potentially many times.

caicancai
caicancai approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@caicancai caicancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NobiGo NobiGo marked this pull request as draft November 7, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caicancai caicancai caicancai approved these changes

@mihaibudiu mihaibudiu mihaibudiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NobiGo @mihaibudiu @caicancai