Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-6846] Support basic dphyp join reorder algorithm #4204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

silundong
Copy link

@silundong silundong commented Feb 19, 2025

The main enumeration process of dphyp has been implemented. There are two new rules, one for converting Joins into a HyperGraph and the other for triggering the dphyp algorithm. More details could see:https://issues.apache.org/jira/browse/CALCITE-6846

@silundong silundong closed this Feb 19, 2025
@silundong silundong deleted the dphyp branch February 19, 2025 11:49
@silundong silundong restored the dphyp branch February 19, 2025 11:52
@silundong silundong reopened this Feb 19, 2025
@silundong silundong force-pushed the dphyp branch 3 times, most recently from 2e00af5 to 658371b Compare February 20, 2025 10:52
@mihaibudiu
Copy link
Contributor

Is this ready for review?
If not, please mark as draft.

@silundong
Copy link
Author

Is this ready for review? If not, please mark as draft.

Ready, please review.
There are still some checks that are not passed, but I think I have taken care of them in the code. Can you give me some advice on how to pass these checks?

@NobiGo
Copy link
Contributor

NobiGo commented Feb 21, 2025

Some parameters might need to be checked whether they are NULL or undergo active type conversion.

@silundong
Copy link
Author

Some parameters might need to be checked whether they are NULL or undergo active type conversion.

Thank you, I will update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants