-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP-Cassgo 33 snappy has been moved to a separate package #1844
Open
OleksiienkoMykyta
wants to merge
27
commits into
apache:trunk
Choose a base branch
from
OleksiienkoMykyta:CASSGO-33-snappy-has-been-moved-to-a-separate-package
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP-Cassgo 33 snappy has been moved to a separate package #1844
OleksiienkoMykyta
wants to merge
27
commits into
apache:trunk
from
OleksiienkoMykyta:CASSGO-33-snappy-has-been-moved-to-a-separate-package
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to ver < 5. Using ptr based logic for now_in_seconds field instead of additional flag
…orthIt integration tests
…n METADATA_CHANGED is presented in ROWS/RESULT only if the prepared stmt is presented in the cache
2. The driver should relly on No_metadata flag instead of Skip_metadata when handling RESULT/ROWS responses from C*
…_changed handling logic by forcing the driver to execute queries with old metadata 2. Added checking of integrity of the result to the test
…rent code base uses initial keyspace provided by the user to construct the keys. Since proto v5 we also should account for keyspace bounding for a specific query, so the driver should use the bounded keyspace instead of the initial to construct the key. 2. Changed the way how routing key cache keys are constructed to account the keyspace overriding as well.
…CacheUsesOverriddenKeyspace integration tests when running on proto < 5 because they requires overridding keyspace feature that is available for proto 5 and higher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be reviewed right after #1822 is merged.