Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS console warnings: Invalid DOM properties in js,mdx,tsx files #246

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

jbampton
Copy link
Member

https://stackoverflow.com/questions/30968113/warning-unknown-dom-property-class-did-you-mean-classname

Warnings seen in the web browser JS console on full page reloads.

To reproduce the warnings in Firefox Desktop browser locally:

  • use branch staging-site and yarn start the website
  • open the web developer tools and then the console tab and reload the pages to see the warnings

Whilst the site still works the warnings fill up the browser console with lots of messages and make it harder to debug and develop. We should also use the correct "react" syntax.

Example:

Screenshot from 2024-09-18 06-37-16

@jbampton jbampton marked this pull request as draft September 17, 2024 21:27
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tnx @jbampton , looks good

@DaanHoogland
Copy link
Contributor

@jbampton I resolved the conflicts with your other PRs. Do you need some testing or other help on this?

@jbampton jbampton marked this pull request as ready for review September 23, 2024 13:17
@jbampton
Copy link
Member Author

Ready to merge @DaanHoogland

@DaanHoogland DaanHoogland merged commit 772a254 into apache:staging-site Sep 23, 2024
3 checks passed
@jbampton jbampton deleted the react-fixes branch September 23, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants