server: prevent duplicate HA works and alerts

[shwstppr]

Description

Fixes #10367

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (95c2481) to head (4e622f3).
Report is 10 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...java/com/cloud/ha/dao/HighAvailabilityDaoImpl.java	0.00%	9 Missing ⚠️
...java/com/cloud/ha/HighAvailabilityManagerImpl.java	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10624   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11326    11327    +1     
=========================================
  Files          5414     5414           
  Lines        474804   474827   +23     
  Branches      57909    57911    +2     
=========================================
+ Hits          72002    72013   +11     
- Misses       394749   394762   +13     
+ Partials       8053     8052    -1     

Flag	Coverage Δ
uitests	4.28% <ø> (-0.01%)	⬇️
unittests	15.89% <15.38%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sureshanaparti]

clgtm

[shwstppr]

@DaanHoogland @sureshanaparti just a heads up, I'm still investigating more on this. I'm looking into AgentManagerImpl to not call HA process using HighAvailabilityManagerImpl multiple times.

[sureshanaparti]

@DaanHoogland @sureshanaparti just a heads up, I'm still investigating more on this. I'm looking into AgentManagerImpl to not call HA process using HighAvailabilityManagerImpl multiple times.

@shwstppr will re-check once these changes are updated, thanks for letting us know.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12900

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12962

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12884)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48859 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10624-t12884-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File