find vms regression fix

[DaanHoogland]

Description

This PR...

Fixes: #10634

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[DaanHoogland]

@blueorangutan package

[nvazquez]

Can we rename the findVm method to something similar to findVmThroughPropertiesEx and rename this findVm2 method to findVm? This way we can redirect all the existing usages of the method to it. Then we could invoke findVmThroughPropertiesEx to the listUnmanagedInstances execution

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (ee94ae5) to head (90b38d5).
Report is 2 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...a/com/cloud/hypervisor/vmware/mo/DatacenterMO.java	0.00%	36 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10647      +/-   ##
============================================
- Coverage     15.16%   15.16%   -0.01%     
  Complexity    11328    11328              
============================================
  Files          5415     5415              
  Lines        474824   474860      +36     
  Branches      57912    57913       +1     
============================================
+ Hits          72014    72017       +3     
- Misses       394757   394792      +35     
+ Partials       8053     8051       -2     

Flag	Coverage Δ
uitests	4.28% <ø> (-0.01%)	⬇️
unittests	15.89% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12977