-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): Prevent mix build phases #933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I don't remember off-hand what the plugins/android.json
and plugins/ios.json
files are used for (ideally they wouldn't be necessary since they duplicate what's already listed in package.json?), but I know the order of the plugins in package.json is important for load ordering issues.
You might need to add a mock for something in the tests, they seem to be unhappy. |
Fixed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #933 +/- ##
==========================================
+ Coverage 87.92% 87.95% +0.02%
==========================================
Files 46 46
Lines 2129 2134 +5
==========================================
+ Hits 1872 1877 +5
Misses 257 257 ☔ View full report in Codecov by Sentry. |
Platforms affected
Any
Motivation and Context
Different installation orders for currently installed plugins
iOS
https://github.com/MaximBelov/reproduce-cordova-apply-plugins-sort/blob/20ab95bca8aef992aa5b1982b38e5e6d750580a8/plugins/ios.json
Android
https://github.com/MaximBelov/reproduce-cordova-apply-plugins-sort/blob/20ab95bca8aef992aa5b1982b38e5e6d750580a8/plugins/android.json
Plugins installation order should be the same for any platform and have the source of faithful from package.json
Why is this important?
ios: Prevent mix build phases
The plugin
cordova-plugin-firebasex
runs a hook that adds a new Build Phase "Crashlytics", which should be the last onedpa99c/cordova-plugin-firebasex#897
Description
How to reproduce
https://github.com/MaximBelov/reproduce-cordova-apply-plugins-sort
Testing
How to reproduce
Repository: https://github.com/MaximBelov/reproduce-cordova-apply-plugins-sort
Version without patch
Result:
Version with patch
Result:
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)