Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep(npm): bump @cordova/[email protected] w/ lint corrections #94

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

breautek
Copy link
Contributor

@breautek breautek commented Jul 2, 2024

Platforms affected

Web/JS

Motivation and Context

Upgrades our lint config to the latest available version and applied --fix

Depends on: #93

Description

ESLint was being dumb in one location:

Screenshot from 2024-07-02 11-25-29

Where lint was confident that id was never reassigned even though it was just after the win function is declared. It wanted the id declare to be a const, which obviously failed cause it needed to be initialised with a value at declaration.

There was 2 workarounds, bring the let id into the describe block slope or move the declaration down and use const. I opted for the latter since there was no other tests, but I have no objection to bring the declaration to the describe block either.

Testing

Ran npm run lint

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek mentioned this pull request Jul 2, 2024
5 tasks
@erisu erisu changed the title Lint upgrade dep(npm): bump @cordova/[email protected] w/ lint corrections Jul 4, 2024
@breautek breautek merged commit 8f0ea40 into apache:master Jul 4, 2024
4 of 10 checks passed
@breautek breautek deleted the lint-upgrade branch July 4, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants