Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Web/JS
Motivation and Context
Upgrades our lint config to the latest available version and applied
--fix
Depends on: #93
Description
ESLint was being dumb in one location:
Where lint was confident that
id
was never reassigned even though it was just after thewin
function is declared. It wanted theid
declare to be aconst
, which obviously failed cause it needed to be initialised with a value at declaration.There was 2 workarounds, bring the
let id
into thedescribe
block slope or move the declaration down and useconst
. I opted for the latter since there was no other tests, but I have no objection to bring the declaration to thedescribe
block either.Testing
Ran
npm run lint
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)