Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(android): cleanup obsolete code #309

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

breautek
Copy link
Contributor

Platforms affected

Android

Motivation and Context

Depends on #308

Improved maintenance

Description

Cleanup unused imports, redundant if conditions, and unused private methods.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu changed the title Cleanup obsolete code refactor(android): cleanup obsolete code Dec 27, 2024
@erisu
Copy link
Member

erisu commented Dec 27, 2024

When squash merging, make sure the commit title contains the updated refactor(android):

I noticed the current commit title missing the platform as checklist requested:

Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other then commit message, everything else looks good.

@breautek breautek force-pushed the cleanup-obsolete-code branch from 33714bc to 949370e Compare December 28, 2024 19:28
@breautek breautek merged commit ce42ab4 into apache:master Dec 28, 2024
14 of 15 checks passed
@breautek breautek deleted the cleanup-obsolete-code branch December 28, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants