WIP RAT-336: Start to migrate tests in first module #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottlinger
commented
Jun 4, 2024
| @@ -110,8 +107,7 @@ public void testEmbeddedStrings(String id, String family, String name, String no | |||
| for (String fmt : formats) { | |||
| boolean found = processText(license, String.format(fmt, target[TEXT])); | |||
| license.reset(); | |||
| assertTrue(found, () -> String.format("%s %s did not match pattern '%s' for target string %s", id, | |||
There was a problem hiding this comment.
@Claudenw it seems that assertJ has no equivalent to this supplier construct.
Do you have an idea how to transform these kind of tests into assertJ or should we leave the other assertTrue() - WDYT?
There was a problem hiding this comment.
You could generate the message string and just use it. It will have some performance impact. Or you could just leave the junit 5 format
There was a problem hiding this comment.
I never worked with that construct before and wondered what it is good for. Thx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to migrate to AssertJ assertions .....