Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: RAT-293: Add properties for SonarCloud integration #33

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ottlinger
Copy link
Contributor

@ottlinger ottlinger commented Dec 30, 2021

Allow RAT to integrate with Sonarcloud.io-scanning services.

https://issues.apache.org/jira/browse/RAT-293

@ottlinger ottlinger self-assigned this Dec 30, 2021
@ottlinger
Copy link
Contributor Author

Problems with animal-sniffer/jdk8-compliance:

[ERROR] Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar (default-cli) on project apache-rat-project: Execution default-cli of goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar failed: An API incompatibility was encountered while executing org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar: java.lang.UnsupportedClassVersionError: org/sonar/batch/bootstrapper/EnvironmentInformation has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
[ERROR] -----------------------------------------------------
[ERROR] realm =    plugin>org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy

Copy link
Contributor

@Claudenw Claudenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple. Is there any reason not to merge this?

@ottlinger
Copy link
Contributor Author

Looks simple. Is there any reason not to merge this?

This cannot be merged as long as Sonar's plugin is not compiled with Java8 as it breaks our "JDK-8-only animal sniffer check" OR
we decide to drop our hard-JDK8-compliance.

@Claudenw
Copy link
Contributor

Claudenw commented May 7, 2024

We could compile under multiple JDKs 8 and 20 for example. We should be dropping 8 in the next couple of years.

@Claudenw
Copy link
Contributor

Now that we are testing under multiple JVM versions it should be possible to add the SonarCloud under a profile that runs when the JVM is not Java8. At least I think this is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants