Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAT-98: changed 'name matcher' to 'document excluder' #422

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

Claudenw
Copy link
Contributor

@Claudenw Claudenw commented Jan 12, 2025

Changed name of variable(s) and method to be lexically correct. It is not a document name matcher but rather an excluder.

Part of #417 simplification.

@Claudenw Claudenw requested a review from ottlinger January 12, 2025 17:38
@Claudenw Claudenw self-assigned this Jan 12, 2025
@Claudenw Claudenw marked this pull request as ready for review January 12, 2025 17:38
@ottlinger ottlinger changed the title changed 'name matcher' to 'document excluder' RAT-98: changed 'name matcher' to 'document excluder' Jan 12, 2025
@ottlinger
Copy link
Contributor

ottlinger commented Jan 12, 2025

@Claudenw when I read the description I thought of "FilterEntrySkipper" or "DocumentSkipper/FilterSkipper" ;) Not sure if DocumentExcluder is an easier2understand name. Should the class be renamed as well since DocumentNameMatcher seems rather "abstract" .... if it skips entries in the filtering/scanning process.

@Claudenw
Copy link
Contributor Author

@Claudenw when I read the description I thought of "FilterEntrySkipper" or "DocumentSkipper/FilterSkipper" ;) Not sure if DocumentExcluder is an easier2understand name. Should the class be renamed as well since DocumentNameMatcher seems rather "abstract" .... if it skips entries in the filtering/scanning process.

@ottlinger

The DocumentNameMatcher is untouched in this PR. It does what it says. It matches document names.

The excluder is a use of the document matcher. That is documents that match it are excluded. When reading the code it begins to make more sense and when debugging it is much easier to remember that if the name matches the excluder it is excluded.

I am open to other names but would prefer not to rename the DocumentNameMatcher in this PR.

Copy link
Contributor

@ottlinger ottlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - go ahead and merge @Claudenw

@Claudenw Claudenw merged commit fb6d3b3 into apache:master Jan 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants