WHISKER-18: Migrate to log4j2

[ottlinger]

• Raise minimum Maven version to 3.1.0 to benefit from slf4 log bridging
• Replace deprecated velocity parameters
• Remove old logging implementation in favor of standard log4j2

[ottlinger]

@Claudenw @jochenw do you have a chance to have a look into this branch from a Windows-system? The tests seem to fail, but the build does not emit what went wrong during the integration test runs of the Maven plugin. Thanks
(tests work fine on Mac and linux)

[Claudenw]

Philipp Have you founda fix for this or is it still an issue?

…

On Mon 16 Dec 2024, 22:57 P. Ottlinger, ***@***.***> wrote: @Claudenw <https://github.com/Claudenw> @jochenw <https://github.com/jochenw> do you have a chance to have a look into this branch from a Windows-system? The tests seem to fail, but the build does not emit what went wrong during the integration test runs of the Maven plugin. Thanks (tests work fine on Mac and linux) — Reply to this email directly, view it on GitHub <#215 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASTVHVJ4ORIYZT3TLLLTYD2F5LE3AVCNFSM6AAAAABTXDL3NGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBXGA2DSOJRG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ottlinger]

@Claudenw The issue remains open. I asked a friend to checkout the branch and build and it succeeded on Windows10, not sure what OS GHA is running - the last message is

[INFO] --- invoker:3.6.0:run (integration-test) @ apache-whisker-maven-plugin ---
[INFO] Building: example-copyright-notices\pom.xml
[INFO] run post-build script verify.groovy
[INFO]   groovy.lang.MissingMethodException: No signature of method: org.apache.creadur.whisker.it.Results.report() is applicable for argument types: () values: []
Possible solutions: every(), grep(), every(groovy.lang.Closure), getAt(java.lang.String), grep(java.lang.Object), split(groovy.lang.Closure)
[INFO]           example-copyright-notices\pom.xml ................ FAILED (10.49 s)
[INFO] Building: in-5\pom.xml
[INFO] run post-build script verify.groovy
[INFO]   Assertion failed: 

assert license.exists()
       |       |
       |       false
       D:\a\creadur-whisker\creadur-whisker\apache-whisker-maven-plugin\target\it\in-5\target\LICENSE

as the file seems to exist my expectation would be to see true instead of false.

[Claudenw]

@ottlinger you could try adding <goal>-X</goal> to the invoker plugin configuration in the maven-plugin pom. That will cause the debugging to print and may help debug the problem.

[ottlinger]

@ottlinger you could try adding <goal>-X</goal> to the invoker plugin configuration in the maven-plugin pom. That will cause the debugging to print and may help debug the problem.

Done - I do not understand the initial groovy error ....

[INFO] --- invoker:3.6.0:run (integration-test) @ apache-whisker-maven-plugin ---
[INFO] Building: example-copyright-notices\pom.xml
[INFO] run post-build script verify.groovy
[INFO]   groovy.lang.MissingMethodException: No signature of method: org.apache.creadur.whisker.it.Results.report() is applicable for argument types: () values: []
Possible solutions: every(), grep(), every(groovy.lang.Closure), getAt(java.lang.String), grep(java.lang.Object), split(groovy.lang.Closure)
[INFO]           example-copyright-notices\pom.xml ................ FAILED (10.73 s)
[INFO] Building: in-5\pom.xml
[INFO] run post-build script verify.groovy
[INFO]   Assertion failed: 

assert license.exists()
       |       |
       |       false
       D:\a\creadur-whisker\creadur-whisker\apache-whisker-maven-plugin\target\it\in-5\target\LICENSE

[Claudenw]

Sorry. this should be in the goals section around line 151

[ottlinger]

@Claudenw Unfortunately changing line 151 to

-              <goal>run</goal>
+              <goal>-X run</goal>

does not work and fails the build :(

[ottlinger]

Unfortunately adding invoker properties does not solve the problem as the build.log's contents is not shown in the console/logs :(

[Claudenw]

Approve when