Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to save protobuf plans to disk for debugging #1099

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Related to #1098

Rationale for this change

I would like to be able to save protobuf execution plans to disk and then write benchmarks for deserializing and creating physical plans.

What changes are included in this PR?

WIP

How are these changes tested?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 33.60%. Comparing base (b74bfe4) to head (4197982).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ain/scala/org/apache/comet/CometExecIterator.scala 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1099      +/-   ##
============================================
- Coverage     34.33%   33.60%   -0.74%     
+ Complexity      898      866      -32     
============================================
  Files           115      115              
  Lines         42986    42940      -46     
  Branches       9369     9380      +11     
============================================
- Hits          14761    14431     -330     
- Misses        25361    25645     +284     
  Partials       2864     2864              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants