Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building docker images during CI/CD and publish on tag #29

Merged
merged 3 commits into from
Oct 13, 2024
Merged

Building docker images during CI/CD and publish on tag #29

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9e1923
build docker image
edmondop Oct 11, 2024
0086112
Fixing right dockerfile version
edmondop Oct 11, 2024
434e7b2
Publishing only on tags
edmondop Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/k8s.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: Kubernetes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the ASF license header? It looks like we don't have the RAT checks set up in CI yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also be okay with explicitly excluding GitHub workflows from RAT checks if we had RAT set up, so maybe this is fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and merge so we can test. I added a bullet to #2 for setting up RAT.


on:
push:
pull_request:

jobs:
build:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Log in to GitHub Container Registry
if: startsWith(github.ref, 'refs/tags/')
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push Docker image
uses: docker/build-push-action@v6
with:
context: .
file: ./k8s/Dockerfile
tags: username/repository:tag
# Push only on tags
push: ${{ startsWith(github.ref, 'refs/tags/') }}
Loading